Simplified ssd1306_UpdateScreen(). #43
Conversation
| ssd1306_WriteCommand(0x10); | ||
| ssd1306_WriteData(&SSD1306_Buffer[SSD1306_WIDTH*i],SSD1306_WIDTH); | ||
| } | ||
| #if defined(SSD1306_USE_SPI) |
There was a problem hiding this comment.
I'm afraid I don't get it. Why the code should differ for I2C and SPI?
There was a problem hiding this comment.
Same as a previous code edit:
These three ssd1306_WriteCommand() is used to tell SSD1306 which address do you want to begin to write into. The three are necessary for SPI, but ont necessary for I2C.
Because I2C has function HAL_I2C_Mem_Write_DMA(), you can pass the GRAM start address to it, but I did not find such a function for SPI.
You suggested me to submit this change as a separate PR.
|
@TargetTriple Once again, many thanks for the pull requests. I very much appreciate your desire to improve the library. After thinking about it I decided to decline both pull requests #43 and #45 I don't care much about DMA support, at least at present, and don't feel like maintaining suggested code. I suggest creating a fork of the library if that feels necessary. |
No description provided.