Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daydream support #122

Merged
merged 3 commits into from
Aug 17, 2017
Merged

Daydream support #122

merged 3 commits into from
Aug 17, 2017

Conversation

fernandojsg
Copy link
Member

No description provided.

@dmarcos
Copy link
Member

dmarcos commented Aug 17, 2017

The position of the gun is much better now 🔫

@fernandojsg fernandojsg merged commit 2a336f0 into aframevr:master Aug 17, 2017
@fernandojsg fernandojsg deleted the daydream branch August 17, 2017 21:57
@cvan
Copy link
Contributor

cvan commented Aug 17, 2017

@fernandojsg I just tested this locally, and now I can't seem to be able to shoot. the controller doesn't show up and pressing the Daydream controller's primary button isn't working for me.

@cvan
Copy link
Contributor

cvan commented Aug 17, 2017

it may be just my controller not working. testing that now.

https://webvr.info/samples/XX-vr-controllers.html and https://aframe.io/aframe/examples/showcase/tracked-controls/ best to test with?

@cvan
Copy link
Contributor

cvan commented Aug 17, 2017

  1. https://aframe.io/a-blast/ – I see the gun on the ground, and moving my controller doesn't affect that
  2. https://webvr.info/samples/XX-vr-controllers.html – works correctly with my Daydream controller
  3. https://aframe.io/aframe/examples/showcase/tracked-controls/ – doesn't work with Daydream controller, but I don't see it using Daydream controls, nor in the grab component

@dmarcos
Copy link
Member

dmarcos commented Aug 17, 2017

The canonical example is : https://aframe.io/aframe/examples/test/laser-controls/

@fernandojsg
Copy link
Member Author

@cvan could you give it a try on master? I've just updated a bug with an event, and I've tried both on vive and on daydream and works as expected.

@cvan
Copy link
Contributor

cvan commented Aug 31, 2017

@fernandojsg see issue #126 I filed. it could be the same issue or Gear VR-specific. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants