-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace fontawesome cdn by react-fontawesome #706
Conversation
…ion with collapsible with e.stopPropagation()
I replaced clipboard by clipbard-copy mainly because I couldn't figure out how to stop the click event propagating and collapse the panel. Switching to clipboard-copy reduce a bit the bundle size: We removed downloading https://maxcdn.bootstrapcdn.com/font-awesome/4.5.0/css/font-awesome.min.css here, so 27K less to download as well. Before this PR: increasing bundle to 68kB, wait this doesn't line up, I would had expected 490K maybe. Also just to confirm this wasn't due to bad tree shaking, I replaced import {
faCamera,
faCube,
faFont,
faLightbulb
} from '@fortawesome/free-solid-svg-icons'; to import { faCamera } from '@fortawesome/free-solid-svg-icons/faCamera';
import { faCube } from '@fortawesome/free-solid-svg-icons/faCube';
import { faFont } from '@fortawesome/free-solid-svg-icons/faFont';
import { faLightbulb } from '@fortawesome/free-solid-svg-icons/faLightbulb'; the bundle increased by 3KB TT. |
Thanks so much! |
This closes #692
Some icons slightly changed.
Remaining to do: