Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASD control behaves oddly on Codepen with master #1729

Closed
bryik opened this issue Aug 6, 2016 · 14 comments
Closed

WASD control behaves oddly on Codepen with master #1729

bryik opened this issue Aug 6, 2016 · 14 comments

Comments

@bryik
Copy link
Contributor

bryik commented Aug 6, 2016

Description:

With 0.2.0 I can click on the window and walk around with the WASD keys. But with master, control stays with the editor often resulting in WASD characters being added to code accidentally. Autorun makes this extra frustrating.

Master: http://codepen.io/bryik/pen/dXgQdQ

0.2.0: http://codepen.io/bryik/pen/yJRQKr

  • A-Frame Version: master
  • Platform/Device: Desktop Chrome/Codepen
@bleonard252
Copy link

I would imagine this is an issue regarding CodePen and not A-Frame.

@bryik
Copy link
Contributor Author

bryik commented Aug 6, 2016

@bleonard252 I don't think so, Codepen works fine with A-Frame 0.2.0.

@bleonard252
Copy link

Oh, yeah. Then maybe it's priority? Idk

@ngokevin
Copy link
Member

ngokevin commented Aug 8, 2016

For anyone looking, the code is in src/components/wasd-controls.js

@ngokevin ngokevin added this to the 0.3.0 milestone Aug 11, 2016
@bryik
Copy link
Contributor Author

bryik commented Aug 12, 2016

Hmm, adding a camera with wasd-controls but no look-controls fixes the issue.

I guess the problem is with look-controls?

@ngokevin
Copy link
Member

Some time within the last twelve days of bumping the dist, this has been fixed.

I tried a couple examples in CodePen using the latest master that I generated locally, WASD works again.

@bryik
Copy link
Contributor Author

bryik commented Aug 15, 2016

Are you sure this is fixed? I'm still experiencing the problem with the latest dist: https://codepen.io/bryik/pen/bZzXGP

@ngokevin
Copy link
Member

Weird

@ngokevin
Copy link
Member

@bryik lemme know if this works for you #1797

@bryik
Copy link
Contributor Author

bryik commented Aug 16, 2016

@ngokevin Do you have a link I could try? How do I test it?

@ngokevin
Copy link
Member

Re-working on it, another test shows it didn't work. So flaky :0

@bryik
Copy link
Contributor Author

bryik commented Aug 16, 2016

Dang. The only other clue I came across was that the problem does not occur with the dist from 26 days ago. Not sure if that helps.

Codepen: https://codepen.io/bryik/pen/XKOXWg

@ngokevin
Copy link
Member

OK here's one where I remove event.preventDefault() in look controls canvas mousedown https://codepen.io/ngokevin/pen/AXNZwV

@bryik
Copy link
Contributor Author

bryik commented Aug 16, 2016

Ya, that works!

The grabby hand is gone though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants