Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuring the cursor's raycaster does not work (component ordering/dep bug) #1841

Closed
bryik opened this issue Aug 22, 2016 · 4 comments
Closed

Configuring the cursor's raycaster does not work (component ordering/dep bug) #1841

bryik opened this issue Aug 22, 2016 · 4 comments
Assignees
@ngokevin
Labels
bug
Milestone
0.4.0

Comments

@bryik
Copy link
Contributor

bryik commented Aug 22, 2016

Description: The documentation says we can "customize the raycasting pieces of the cursor...by changing the raycaster component properties". But attempting to restrict the cursor to a certain class using the raycaster's 'objects' property does not work (all entities remain active).

CodePen: https://codepen.io/bryik/pen/VjRgyk

  • A-Frame Version: 0.3.0
  • Platform/Device: Chrome/Windows
bryik added a commit to bryik/aframe-controller-cursor-component that referenced this issue Aug 22, 2016
@bryik
Add objects property and update examples
672813d 
Though it should have been possible to update the raycaster
independently, an A-Frame bug makes it necessary to go through the
vive-cursor component.

aframevr/aframe#1841
@bryik
Copy link
Contributor Author

bryik commented Aug 22, 2016 •
edited

This may be caused by confusion between the raycaster created by the cursor (as a dependency) and the raycaster added in markup.

I had the same problem with the vive-cursor component and "solved" it by having the raycaster's 'objects' property be set by vive-cursor during initialization.

@ngokevin ngokevin mentioned this issue Aug 24, 2016
Merged
@ngokevin
Copy link
Member

I got it working in #1845

I wonder if it's a component initialization order issue.

@bryik
Copy link
Contributor Author

bryik commented Aug 24, 2016

I wonder if it's a component initialization order issue.

Putting the raycaster component before the cursor component works as it should.

The code sample on the cursor's doc page could be amended, but ideally the order wouldn't matter.

@ngokevin ngokevin added the bug label Sep 19, 2016
@ngokevin ngokevin added this to the 0.4.0 milestone Oct 24, 2016
@ngokevin ngokevin changed the title Configuring the cursor's raycaster does not work Configuring the cursor's raycaster does not work (component ordering/dep bug) Oct 24, 2016
ngokevin added a commit to ngokevin/aframe that referenced this issue Nov 1, 2016
@ngokevin
fix component dependencies being initialized with no data (fixes afra…
4e6f87b 
…mevr#2033, aframevr#1841, aframevr#1848)
ngokevin added a commit to ngokevin/aframe that referenced this issue Nov 1, 2016
@ngokevin
fix component dependencies being initialized with no data (fixes afra…
053a4a5 
…mevr#2033, aframevr#1841, aframevr#1848)
@ngokevin ngokevin self-assigned this Nov 1, 2016
ngokevin added a commit to ngokevin/aframe that referenced this issue Nov 2, 2016
@ngokevin
fix component dependencies being initialized with no data (fixes afra…
f1d1a3d 
…mevr#2033, aframevr#1841, aframevr#1848)
dmarcos pushed a commit that referenced this issue Nov 3, 2016
@ngokevin @dmarcos
fix component dependencies being initialized with no data (fixes #2033,
f91ab53 
#1841, #1848) (#2036)

* fix component dependencies being initialized with no data (fixes #2033, #1841, #1848)

* address dependencies init with no data
@ngokevin
Copy link
Member

ngokevin commented Nov 3, 2016

fixed

@ngokevin ngokevin closed this as completed Nov 3, 2016
@arpu arpu mentioned this issue Jul 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ngokevin ngokevin

Labels
bug
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
2 participants
@ngokevin @bryik