fix component dependencies being initialized with no data (fixes #2033, #1841, #1848) #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcos
reviewed
Nov 1, 2016
| // On debug mode we write the component state to the DOM attributes | ||
|
|
||
| // On debug mode we write the component state to the DOM attributes. | ||
| isDebugMode = this.sceneEl && this.sceneEl.getAttribute('debug'); |
There was a problem hiding this comment.
I would leave the variables at top. If you want to reuse the same variable somewhere else in the function you have to remember to move it to the top or at least above the other place you want to use it.
| // Call getAttribute to initialize the data from the DOM. | ||
| self.initComponent( | ||
| componentName, | ||
| HTMLElement.prototype.getAttribute.call(self, componentName), |
There was a problem hiding this comment.
If the dependency is not defined in the entity this will pass a null to the initComponet function. What are the consequences?
There was a problem hiding this comment.
I guess I should do || undefined and add a test case.
There was a problem hiding this comment.
At some point (I cannot longer tell you if the case) a null value was interpreted as a component being removed. This is why undefined value was passed before.
|
updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With investigation help from @GavanWilhite.
initComponentininitComponentDependencieswas being called withundefinedrather than reading data from the DOM. The component later initializes with a null data set because components themselves never fetch data from the DOM; they depend on the entity to pass data to them.Changes proposed:
initComponentfor dependencies using data from the DOM (HTMLElement.prototype.getAttribute).