Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<a-scene background=""> #2908

Closed
mrdoob opened this issue Jul 27, 2017 · 2 comments · Fixed by #3277
Closed

<a-scene background=""> #2908

mrdoob opened this issue Jul 27, 2017 · 2 comments · Fixed by #3277

Comments

@mrdoob
Copy link
Contributor

mrdoob commented Jul 27, 2017

three.js r87 will bring a optimized handling of scene.background and should work nicely in VR.

https://github.com/mrdoob/three.js/blob/dev/src/renderers/webgl/WebGLBackground.js#L26-L108

I think a-frame should add support for this. Right now I see people creating spheres and adding them to the scene which is not the most optimal way of doing it.

Maybe <a-background> as a component could also work. That way one could add more logic to it like converting equirectangular to cubemaps (using CubeCamera) automatically.

@dmarcos
Copy link
Member

dmarcos commented Jul 27, 2017

👍

@michaelybecker
Copy link
Contributor

michaelybecker commented Oct 2, 2017

What an awesome addition!

I'm thinking <a-scene background='whatever'> would be more in line with the existing API - @mrdoob , can you please elaborate about the reasoning for <a-background> and the connection to the automatic cubemap conversion? Is there already a way to do that in three or is that a proposed feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants