fix dynamically-attached entities not playing due to load conditions (fixes #1383) #1415
Conversation
ngokevin
changed the title
| } | ||
| } else { | ||
| // To handle elements that are not yet `<a-entity>`s (e.g., templates). | ||
| el.addEventListener('nodeready', init.bind(self)); |
There was a problem hiding this comment.
we don't listen to the nodeready event anymore?
There was a problem hiding this comment.
Those were leftover from <a-template>.
|
@dmarcos r? |
| } | ||
|
|
||
| // Entity load. | ||
| function entityLoadCallback () { |
There was a problem hiding this comment.
Can we move this function to the bottom of the function after ANode.prototype.load.call(this, entityLoadCallback, isEntity);?
There was a problem hiding this comment.
any reason to? seems more consistent with doing vars-on-top since these functions get hoisted. and readability-wise, it makes sense to want to know what this function is doing in the context of the method.
There was a problem hiding this comment.
The function gets in the way of understanding the main body of the function. I want to see what the function does first and maybe later want to see what happens asynchronously when the entity loads.
There was a problem hiding this comment.
I'll change this later in a follow up PR
There was a problem hiding this comment.
the function is integral to understanding what the function does though. it's only separated because it's awkward to inline
Description:
Caught this using the template component that dynamically attached entities that also had the template component to dynamically attach entities.
play()loadedChanges proposed:
play()after they are loaded..bindcalls.