Change user (eye) userHeight from 1.8 to 1.6 #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks good. Waiting for tests to pass. |
|
yeah travis had false alarm there due (network timeout) and is now re running the tests. |
|
Yup, I restarted it. |
| @@ -2,7 +2,9 @@ var registerPrimitive = require('../primitives').registerPrimitive; | |||
|
|
|||
| registerPrimitive('a-camera', { | |||
| defaultComponents: { | |||
| camera: {}, | |||
| camera: { | |||
There was a problem hiding this comment.
@dmarcos across other primitives single values are not
JChehe
added a commit
to JChehe/aframe
that referenced
this pull request
Aug 18, 2016
CHANGELOG.md says "Default camera is now positioned at 0, 1.6, 0 rather than 0, 1.8, -4. In VR mode, the 1.6m height offset as defined by camera.userHeight is removed. (aframevr#1474, aframevr#1718)" but in v0.3 doc, still v0.2 value of Default camera position. My English is so poor~Sorry
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1717