-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It removes the ability to provide an external canvas. The canvas size… #1474
Conversation
@@ -65,11 +65,30 @@ module.exports = registerElement('a-scene', { | |||
this.setupRenderer(); | |||
this.resize(); | |||
}); | |||
if (!this.hasAttribute('embedded')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Componentize to keep scene uncluttered?
Should we add a test example showing multiple scenes on a page? |
I don't think multiple scenes per page works quite yet |
5c87917
to
dacfc03
Compare
@@ -0,0 +1,13 @@ | |||
var register = require('../../core/component').registerComponent; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
registerComponent to be consistent
35ee462
to
80b03ed
Compare
The offset in the y axis should still apply |
Yeah, I'm just talking about the Y-axis. Try the geometry gallery scene and enter fullscreen (non-VR). |
302771c
to
a868b9e
Compare
I believed I covered all the cases: Desktop with and without headset, mobile, scenes with and without default camera. I have to do one more round of tests with a headset. |
defaultCameraEl.setAttribute(DEFAULT_CAMERA_ATTR, ''); | ||
defaultCameraEl.setAttribute('camera', {'active': true}); | ||
defaultCameraEl.setAttribute('wasd-controls', ''); | ||
defaultCameraEl.setAttribute('look-controls', ''); | ||
sceneEl.appendChild(defaultCameraEl); | ||
// Adding defautlt offset to the camera |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
|
a868b9e
to
846bbe1
Compare
Ready to go. The offset in the y is now applied to all cameras and configured via the |
… and positioning can be controled styling the a-scene when adding the embedded attribute
846bbe1
to
f420a45
Compare
very nice |
r+ when you ready to merge |
I would probably add |
@ngokevin can you test a bit to see if everything make sense? |
I tested around a few examples on my laptop, everything makes sense there:
I haven't tested in VR. But I assume you have this:
Just the one note that if I did |
We can decide on the user-defined |
Nice. Love resolving the camera height inside and outside VR. |
If we're nitpicking eyeheight would rather be 1.6 m ... |
CHANGELOG.md says "Default camera is now positioned at 0, 1.6, 0 rather than 0, 1.8, -4. In VR mode, the 1.6m height offset as defined by camera.userHeight is removed. (aframevr#1474, aframevr#1718)" but in v0.3 doc, still v0.2 value of Default camera position. My English is so poor~Sorry
… and positioning can be controled styling the a-scene when adding the embedded attribute