remove event.preventDefault in look-controls canvas mousedown (fixes #1729) #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does fix the issue, but the grabbing cursor is gone. |
|
Oops, I updated the CodePen. Didn't have look-controls attached... |
|
All good with the CodePen now. |
|
Yes that seemed to solve it |
Current coverage is 81.94% (diff: 100%)@@ master #1798 diff @@
==========================================
Files 100 100
Lines 3546 3545 -1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 2906 2905 -1
Misses 640 640
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
https://codepen.io/ngokevin/pen/AXNZwV
Allow CodePen to listen to click of the scene to blur their text editor.