Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce buffer scale to 0.5 for iOS safari < 10 (fixes #1714) #1803

Merged
merged 1 commit into from
Aug 17, 2016

Conversation

ngokevin
Copy link
Member

@ngokevin ngokevin commented Aug 16, 2016

Description:

Workaround for Webkit bug on iOS Safari < 10.

Before

Upon Entering VR from landscape without orientation change:

img_3576

After

Stereo now sized correctly, at the cost of decreased resolution. With the version check, this should automatically be addressed once people upgrade to iOS 10 as the Webkit patch rolls out.

img_3575

@ngokevin ngokevin added this to the 0.3.0 milestone Aug 16, 2016
@codecov-io
Copy link

codecov-io commented Aug 16, 2016

Current coverage is 81.93% (diff: 50.00%)

No coverage report found for master at a8b3c4c.

Powered by Codecov. Last update a8b3c4c...05deb4d

@dmarcos
Copy link
Member

dmarcos commented Aug 16, 2016

I have to try this tomorrow on my iphone 6 Plus that has devicePixelRatio === 3

@dmarcos
Copy link
Member

dmarcos commented Aug 16, 2016

The canvas size gets fixed when turning the phone to portrait and back to landscape. Is avoiding that glitch more important than keeping the high resolution?

@ngokevin
Copy link
Member Author

I think so, I don't think it's acceptable that people (not developers) have to know to rotate their phone back and forth. Many would think it was just broken and leave. With the version check, trying to have it automatically be addressed once iOS 10 starts rolling out.

I'll change it to 1 / window.devicePixelRatio then for iPhone Plus.

@dmarcos
Copy link
Member

dmarcos commented Aug 16, 2016

Yes, I confirm we need 1 / window.devicePixelRatio to make it work on the iphone6 Plus

@dmarcos dmarcos merged commit b4f0af1 into aframevr:master Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants