lax the asset parser, remove no longer needed primitives.transform (fixes #2038) #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngokevin
force-pushed
the
updateassetparse
branch
from
877eeb7
to
b4e643b
Compare
ngokevin
force-pushed
the
updateassetparse
branch
2 times, most recently
from
01b1495
to
b434bdc
Compare
ngokevin
force-pushed
the
updateassetparse
branch
from
b434bdc
to
3c9a5d6
Compare
|
rebased |
|
Thanks for the reviews 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allows URL properties to be just a string, for a more lenient API. Keep
url()as a solution to escape semicolons or for data URIs. Lets us remove the primitives transform API.