Make sure that init/update are not called when invoking flushToDOM on a non loaded entity

[dmarcos]

Fixes inspector aframevr/aframe-inspector#409

[ngokevin]

Can you explain the remove of the updateCachedAttrValue line and the using attr vs. this.attrValue?

[dmarcos]

It's not removed. It's now part of updateProperties. It was redundant before in the constructor since it is done in updateProperties as well

[ngokevin]

I'm confused that we're now passing attr (presumably the attribute name) into updateProperties now when before we were passing an attrValue, and the function seems to expect an attrValue.

[dmarcos]

this.attrValue is updated by updateAttrForCache. Now everything happens inside updateProperties

[ngokevin]

OK. It seems like something needs to change then, either the function signature or what we pass into updateProperties:

var Component = module.exports.Component = function (el, attr, id) {
  // ...
  this.updateProperties(attr);  // THIS IS THE ATTRIBUTE NAME.
  // ...
};

Component.prototype = {
  // ...
  /**
   * @param {string} value - HTML attribute value.
   */
  updateProperties: function (value) {
    // ...
    // BUT THIS FUNCTION DOC / VAR NAME EXPECTS AN ATTRIBUTE VALUE.
    if (value !== undefined) { this.updateCachedAttrValue(value); }
  }
}

[dmarcos]

The jsdoc for the component constructor was wrong. attr was actually the value of the attribute and not the name. I fixed it.

[ngokevin]

r+