Exit fullscreen when on ExitVR() #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngokevin
reviewed
Jan 10, 2017
| if (!this.is('vr-mode')) { return Promise.resolve(); } | ||
| if (checkHeadsetConnected() || this.isMobile) { | ||
| return this.effect.exitPresent().then(exitVRSuccess, exitVRFailure); | ||
| } | ||
| exitVRSuccess(); | ||
| function exitFullscreen () { |
There was a problem hiding this comment.
Could move this down to where the enter fullscreen function is
ngokevin
reviewed
Jan 10, 2017
| @@ -184,11 +184,21 @@ module.exports = registerElement('a-scene', { | |||
| exitVR: { | |||
| value: function () { | |||
| var self = this; | |||
| exitFullscreen(); | |||
There was a problem hiding this comment.
We should call this after the not-in-VR check below
There was a problem hiding this comment.
I think it won't work. Just entering fullscreen does not set the state to vr-mode
There was a problem hiding this comment.
|
r+wc |
fernandojsg
force-pushed
the
fullscreen
branch
from
5eb5df7
to
2827e46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if we call
scene.exitVR()it will just go back to the standard state if we are on VR but not if we're just in fullscreen mode. This PR introduces a call toexitFullScreenon theexitVRfunction.