Remove quest 2 controller offsets #5141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re-oriented target rays in correct position and direction realigntargetray.mp4 |
|
Thanks so much! 🥳 Merging this. For the ray we should eventually move to use the pose and Noticed the Quest Pro controllers render super dark. Maybe something we can address also in the future. Have a great weekend! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove quest 2 controller offsets now that the controller are directly getting transform data from gripSpace instead of targetRaySpace. (based on 88e8db1) @dmarcos
aligncontroller.mp4
We will still need to address the ray orientation problem separately