Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add travis integration #60

Merged
merged 1 commit into from
Aug 1, 2015
Merged

add travis integration #60

merged 1 commit into from
Aug 1, 2015

Conversation

agallou
Copy link
Member

@agallou agallou commented Jul 30, 2015

Runs PHPCS on travis.

cf #59

Runs PHPCS on travis.
@woecifaun
Copy link
Contributor

@agallou do you have your PHPCS fixed?

when I run bin/coke on master branch, I still have the multiline signature issue.

FILE: ...UP/HaphpyBirthdayBundle/Form/Converter/ContributionConverter.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 40 | ERROR | [x] Opening brace should be on a new line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Vendor versions

m6web/coke                           v2.1.0
m6web/symfony2-coding-standard       v3.0.0
squizlabs/php_codesniffer            2.3.3

@woecifaun
Copy link
Contributor

Otherwise I think it's a great idea to have it run automatically. Thanks.

@woecifaun
Copy link
Contributor

Here it is.

The @M6Web Symfony2 Coding Standards lost its compatibility to multiline function signature when updating Symfony2 coding standard to PHP_CodeSniffer v2 interface.

I made a PR to fix it. BedrockStreaming/Symfony2-coding-standard#11

woecifaun added a commit that referenced this pull request Aug 1, 2015
@woecifaun woecifaun merged commit b534c57 into afup:master Aug 1, 2015
@woecifaun woecifaun mentioned this pull request Aug 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants