-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store coupling file info on disk #33
Comments
What is your use case? For example what command are you using?
Currently it caches in memory with `code-compass-coupling-project-map`
because I may have called the
`code-compass-create-todos-from-coupled-files` function on the
repository and didn't want to wait all that time. I didn't integrate
that into the graphic analysis for coupling I think.
Probably it is just a matter of integrating that caching with some sort
of serialization, but I need to understand what are you trying to achieve.
…On Thu 16 Feb 2023 at 11:18, Gopar ***@***.***> wrote:
Would be nice to save a cached version of the coupling results.
Thoughts:
when calculating the coupling results it would be nice to take a snapshot of the current head commit and branch.
Reasoning:
* if head commit changes, then cached results might not be valid
* Same reasoning for current branch
* if we match on both of these, then retrieve results, otherwise re-calculate
* We could save on directory {$code_compass_home}/.coupling_files/commit_hash ? ¯_(ツ)_/¯
Not sure if this makes sense or is too ambitious.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
|
When I run |
that makes sense. It seems all we need is to serialize at this point https://github.com/ag91/code-compass/blob/main/code-compass.el#L896
That would serialize by project. The branch capabilities would need some extension, but probably that would be a good first step. |
This modifies the key for the hashmap to include the revision hash. This makes some of the code introduced for #33 redundant. I removed also the backend check because that concern is cross cutting and I would need a significant refactor of code if anybody ever asks for support for other VCS. Closes #38.
Would be nice to save a cached version of the coupling results.
Thoughts:
when calculating the coupling results it would be nice to take a snapshot of the current head commit and branch.
Reasoning:
{$code_compass_home}/.coupling_files/commit_hash
? ¯_(ツ)_/¯Not sure if this makes sense or is too ambitious.
The text was updated successfully, but these errors were encountered: