Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute Bluetooth scans and Beacon mapping on the background thread #19

Merged
merged 3 commits into from
May 7, 2020
Merged

Execute Bluetooth scans and Beacon mapping on the background thread #19

merged 3 commits into from
May 7, 2020

Conversation

agap
Copy link
Owner

@agap agap commented May 7, 2020

Reasons:

  1. Using Bluetooth functionality on the main thread use to lead to the UI thread freezes in past and I'm not sure whether it's still the case; better to be safe than sorry
  2. By moving these ops onto the ScheduledExecutorService and replacing it with the DeterministicScheduler test we can rely on the virtual time instead of the real time which leads to better tests.

@agap agap self-assigned this May 7, 2020
@agap agap merged commit 6a445f7 into master May 7, 2020
@agap agap deleted the feature/background-scans branch May 7, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@agap agap

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@agap