-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Relation.Nullary.Recomputable
plus consequences
#2243
Conversation
Converting to DRAFT for the time being as I haven't had the brain space to revisit the questions above. UPDATED: punting those downstream! |
Now : proofs computed using |
@MatthewDaggitt are you happy with this not being a |
As I understand things, there are (now!) two outstanding issues:
Hope this helps! (And removes any further obstruction to merging...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After review of the latest stuff: it continues to look good and, this time, does look backwards compatible as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Reviewing the irrelevance parts): To me, these look like mainstream uses of irrelevance, not affected by agda/agda#7193
Just need @gallais to re-review. |
And @MatthewDaggitt ? |
Fixes #2199 , and the
Recomputable
andIrrelevant
instances of #2091 .Cherry-picks some of the lower-hanging fruit from #2149 .
Outstanding issues:
recompute
vs.recomputable
vs....⇒recomputable
in all the various places; also the various additions toRelation.Nullary.Negation.Core
; UPDATED sticking withrecompute
for nowData.Empty.Irrelevant
could now be deprecated entirely, but I have not (yet) done so; similarly, there may be knock-on deprecations arising from name choices above; UPDATED no deprecations!(Definite
Probably) Won't do in relation to issues raised as a result of #2199 :Data.Universe
construction for the 'Harrop' universe, asRelation.Nullary.Recomputable.Universe
, with a view to generalising Harrop's results to ones of the form "if everything in𝕌 = (U, El)
isRecomputable
/Irrelevant
/Decidable
... then so too is everything inHarrop 𝕌
etc. (UPDATED: downstream PR, but only once I've figured it out)