Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHC 8.2.1 #2540

Closed
asr opened this issue Apr 10, 2017 · 11 comments
Closed

Support GHC 8.2.1 #2540

asr opened this issue Apr 10, 2017 · 11 comments
Assignees
Labels
ghc support Changes to supported GHC versions ghc-8.2.1 type: enhancement Issues and pull requests about possible improvements
Milestone

Comments

@asr
Copy link
Member

asr commented Apr 10, 2017

Edited on 2017-07-08: Using GHC 8.2.1 RC 3 the current issues are:

@asr asr added ghc-8.2.1 type: task Concerning the development of Agda (not in changelog) labels Apr 10, 2017
@asr asr added this to the 2.5.3 milestone Apr 10, 2017
@asr asr self-assigned this Apr 10, 2017
asr added a commit that referenced this issue Apr 10, 2017
asr added a commit that referenced this issue Apr 10, 2017
The warning was:

  Literal -1 is out of the GHC.Word.Word64 range 0..18446744073709551615
asr added a commit that referenced this issue Apr 30, 2017
asr added a commit that referenced this issue May 8, 2017
Version 1.6.0.0 of the process library is shipped with GHC 8.2.1 RC2.
@asr
Copy link
Member Author

asr commented May 9, 2017

GHC 8.2.1 RC2 is reporting a heap exhausted error only on master when testing #1829:

$ cd test/interaction
$ make Issue1829.cmp
...
{+agda: Heap exhausted;
agda: Current maximum heap size is 4194304 bytes (4 MB).
agda: Use `+RTS -M<size>' to increase it.+}
Accept new error [y/N/q]? 

@andreasabel
Copy link
Member

I think @Saizan and/or @nad should investigate whether ghc 8,2 brings #1829 back or this is just a false alarm.

@asr asr added status: blocked-by-issue This pull request is blocked on an open issue. and removed status: blocked-by-issue This pull request is blocked on an open issue. labels Jun 22, 2017
@asr
Copy link
Member Author

asr commented Jul 8, 2017

While testing the build using GHC 8.2.1 RC 3, I found the following error:

$ make install-bin
...
[15 of 49] Compiling InternalTests.TypeChecking.Coverage.SplitTree ( test/InternalTests/TypeChecking/Coverage/SplitTree.hs, dist-2.5.3/build/internal-tests/internal-tests-tmp/InternalTests/TypeChecking/Coverage/SplitTree.o )

test/InternalTests/TypeChecking/Coverage/SplitTree.hs:14:22: error:
    Variable not in scope:
      defaultArg :: a0 -> Agda.Syntax.Common.Arg Int
   |
14 |     , (3, (SplitAt . defaultArg) <$> choose (1,5) <*> (take 3 <$> listOf1 arbitrary))
   |  

It seems that the first report of this error in Travis was here.

@asr
Copy link
Member Author

asr commented Jul 8, 2017

I can fix the error by adding

import Agda.Syntax.Common

I don't understand why the importation is only required by GHC 8.2.1 RC 3. Any idea?

@andreasabel
Copy link
Member

When I try to load this file into ghci it also complains about defaultArg.

@asr
Copy link
Member Author

asr commented Jul 8, 2017

GHC version?

asr added a commit that referenced this issue Jul 9, 2017
The problem was fixed by removing an unused module.
@asr
Copy link
Member Author

asr commented Jul 9, 2017

The problem was caused by an unused module which is compiled by GHC 8.2.1 RC3 but it isn't compiled by previous versions of GHC including 8.2.1 RC 2. I think GHC 8.2.1 RC3 is doing the right thing.

@andreasabel
Copy link
Member

andreasabel commented Jul 9, 2017

GHC version?

7.10.x

But, surely it should complain about defaultArg. How could it be possibly in scope without the import?

@asr
Copy link
Member Author

asr commented Jul 9, 2017

But, surely it should complain about defaultArg.

Yes.

How could it be possibly in scope without the import?

It isn't possible. GHC/Cabal were ignoring the module. In your case, your load the module in GHCi and you get the expected error.

asr added a commit that referenced this issue Jul 23, 2017
asr added a commit that referenced this issue Jul 23, 2017
There is a test case failing with GHC 8.2.1.
@asr
Copy link
Member Author

asr commented Jul 23, 2017

GHC 8.2.1 was released. Except for a test case failing, Agda supports this version of GHC. I'll file a new issue for reporting the problem with the test case.

@asr asr closed this as completed Jul 23, 2017
asr added a commit that referenced this issue Jul 23, 2017
`make haddock` fails when this flag is on.
@asr
Copy link
Member Author

asr commented Aug 17, 2017

GHC 8.2.1 was released. Except for a test case failing, Agda supports this version of GHC. I'll file a new issue for reporting the problem with the test case.

See #2702.

@asr asr added type: enhancement Issues and pull requests about possible improvements and removed type: task Concerning the development of Agda (not in changelog) labels May 30, 2018
@asr asr changed the title Support for GHC 8.2.1 Support GHC 8.2.1 Apr 24, 2019
@rwe rwe added the ghc support Changes to supported GHC versions label Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ghc support Changes to supported GHC versions ghc-8.2.1 type: enhancement Issues and pull requests about possible improvements
Projects
None yet
Development

No branches or pull requests

3 participants