Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some optimisations #5733

Merged
merged 4 commits into from
Jan 13, 2022
Merged

Some optimisations #5733

merged 4 commits into from
Jan 13, 2022

Conversation

nad
Copy link
Contributor

@nad nad commented Jan 12, 2022 •
edited
Loading

Some optimisations. Partly related to issues #5731 and #5388.

@nad
Copy link
Contributor Author

nad commented Jan 12, 2022

One test failed:

+Issue983.hs:«line»:«col»: error:
+Could not find module ‘Agda.Version’
+Perhaps you meant Data.Version (from base-4.15.0.0)
+Use -v (or `:set -v` in ghci) to see a list of the files searched for.
+|
+6 | import Agda.Version
+| ^^^^^^^^^^^^^^^^^^^

I don't think this has anything to do with my changes, it seems as if the Agda package is not installed in the "right" way. Has anyone encountered this problem before?

@andreasabel
Copy link
Member

I don't think this has anything to do with my changes, it seems as if the Agda package is not installed in the "right" way. Has anyone encountered this problem before?

Yes, I did. This is a known issue that could be related to GHC_ENVIRONMENT (starting with GHC 9).

@nad nad marked this pull request as ready for review January 13, 2022 09:57
@nad nad merged commit e204c14 into master Jan 13, 2022
@nad nad deleted the issues_5731_and_5388 branch January 13, 2022 10:00
@andreasabel andreasabel added this to the 2.6.2.2 milestone Mar 14, 2022
@andreasabel andreasabel mentioned this pull request Mar 15, 2022
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.2.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nad @andreasabel