Only recur for comparing in Glue if φ breaks down #6013
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5955. I added some comments to the code explaining the change. The problem was that, when comparing terms at type
Glue φ T
, the conversion checker would try to decompose φ into faces, and recursively compare each face under the resulting substitutions (this iscompareTermOnFace
/forallFaceMaps
).But some expressions are indecomposable, e.g.
φ i
, and in that case,compareTermOnFace
would try comparingm, n
at type(Glue φ T)[idS]
.. i.e., exactly the situation we started in. Not good for termination!