Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ emacs ] string-trim to combat recent change in pp.el adding newlines #6995

Merged
merged 1 commit into from
Nov 15, 2023
Merged

[ emacs ] string-trim to combat recent change in pp.el adding newlines #6995

merged 1 commit into from
Nov 15, 2023

Conversation

andreasabel
Copy link
Member

Fixes #6953 which reports the symptom and identifies pp.el as cause.
Closes #6983.

@andreasabel
[ emacs ] string-trim to combat recent change in pp.el adding new…
a4ee53a 
…lines

Fixes #6953 which reports the symptom and identifies `pp.el` as cause.
Closes #6983.
@andreasabel andreasabel mentioned this pull request Nov 14, 2023
Closed
@andreasabel andreasabel added this to the 2.6.4.1 milestone Nov 15, 2023
@andreasabel andreasabel added the ux: emacs Issues relating to the Emacs agda2-mode label Nov 15, 2023
@andreasabel andreasabel self-assigned this Nov 15, 2023
@andreasabel andreasabel merged commit 3c80571 into master Nov 15, 2023
7 checks passed
@andreasabel andreasabel deleted the emacs-pp branch November 15, 2023 08:56
@gallais gallais mentioned this pull request Nov 21, 2023
Closed
kutsurak added a commit to kutsurak/agda that referenced this pull request Nov 22, 2023
@kutsurak
[emacs] Drop dependency on pp module
504b188 
Use `prin1-to-string' and `print-escape-newlines' instead of
`pp-to-string' and `pp-escape-newlines'. This should not require calls
to `string-trim' and it should allow agda-mode to work for older
emacsen.

Fixes agda#7005 and addresses properly agda#6954 and agda#6995.
kutsurak added a commit to kutsurak/agda that referenced this pull request Nov 22, 2023
@kutsurak
[emacs] Drop dependency on pp module
036d059 
Use `prin1-to-string` and `print-escape-newlines` instead of
`pp-to-string` and `pp-escape-newlines`. This should not require calls
to `string-trim` and it should allow agda-mode to work for older
emacsen.

Fixes agda#7005 and addresses properly agda#6954 and agda#6995.
@kutsurak kutsurak mentioned this pull request Nov 22, 2023
Merged
andreasabel pushed a commit that referenced this pull request Nov 23, 2023
@kutsurak @andreasabel
[emacs] Drop dependency on pp module
bc71ea8 
Use `prin1-to-string` and `print-escape-newlines` instead of
`pp-to-string` and `pp-escape-newlines`. This should not require calls
to `string-trim` and it should allow agda-mode to work for older
emacsen.

Fixes #7005 and addresses properly #6954 and #6995.
andreasabel pushed a commit that referenced this pull request Nov 23, 2023
@kutsurak @andreasabel
[emacs] Drop dependency on pp module
454a5ec 
Use `prin1-to-string` and `print-escape-newlines` instead of
`pp-to-string` and `pp-escape-newlines`. This should not require calls
to `string-trim` and it should allow agda-mode to work for older
emacsen.

Fixes #7005 and addresses properly #6954 and #6995.
JobPetrovcic pushed a commit to JobPetrovcic/agda that referenced this pull request Apr 12, 2024
@kutsurak @JobPetrovcic
[emacs] Drop dependency on pp module
fb586b7 
Use `prin1-to-string` and `print-escape-newlines` instead of
`pp-to-string` and `pp-escape-newlines`. This should not require calls
to `string-trim` and it should allow agda-mode to work for older
emacsen.

Fixes agda#7005 and addresses properly agda#6954 and agda#6995.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andreasabel andreasabel

Labels
ux: emacs Issues relating to the Emacs agda2-mode
Projects
None yet
Milestone
2.6.4.1
Development

Successfully merging this pull request may close these issues.

Refine command does not work on Emacs 30 Emacs 30 breaks agda mode
1 participant
@andreasabel