Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[emacs] Drop dependency on pp module #7007

Merged
merged 1 commit into from Nov 23, 2023
Merged

[emacs] Drop dependency on pp module #7007

merged 1 commit into from Nov 23, 2023

Conversation

kutsurak
Copy link
Contributor

Use prin1-to-string and print-escape-newlines instead of pp-to-string and pp-escape-newlines. This should not require calls to string-trim and it should allow agda-mode to work for older emacsen.

Fixes #7005 and addresses properly #6954 and #6995.

@kutsurak
[emacs] Drop dependency on pp module
036d059 
Use `prin1-to-string` and `print-escape-newlines` instead of
`pp-to-string` and `pp-escape-newlines`. This should not require calls
to `string-trim` and it should allow agda-mode to work for older
emacsen.

Fixes agda#7005 and addresses properly agda#6954 and agda#6995.
@andreasabel andreasabel added the ux: emacs Issues relating to the Emacs agda2-mode label Nov 23, 2023
@andreasabel andreasabel added this to the 2.6.4.1 milestone Nov 23, 2023
andreasabel
andreasabel approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Merging this for testing.

@andreasabel andreasabel merged commit bc71ea8 into agda:master Nov 23, 2023
8 checks passed
@kutsurak kutsurak mentioned this pull request Nov 23, 2023
Closed
@andreasabel
Copy link
Member

Deployed as Agda 2.6.4.1 RC2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasabel andreasabel andreasabel approved these changes

Assignees
No one assigned
Labels
ux: emacs Issues relating to the Emacs agda2-mode
Projects
None yet
Milestone
2.6.4.1
Development

Successfully merging this pull request may close these issues.

report about Agda-2.6.4.1-candidate
2 participants
@kutsurak @andreasabel