Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for reflection of partial elements. #7287

Merged

Conversation

marcinjangrzybowski
Copy link
Contributor

Preventing of unfolding definitioons containing face constraints patterns while translating Internal representation to Reflected.

Although this will leak generated definitions, we can still reduce them in macros by applying them to interval ends, assuming we know the type of partial elements (which is the case for tactics where we inspect partial elements as arguments to hcomps). When used in this manner, the names of generated definitions are not leaking outside the macro. I have wrapped this approach into a set of helpers-macros, and from that point, the tactic can be abstracted over that helpers. I tested this in practice with very good results. (link to relevant PR for cubical will follow).

@marcinjangrzybowski
Copy link
Contributor Author

@plt-amy here is promissed PR to cubical library
agda/cubical#1150

@plt-amy
Copy link
Member

plt-amy commented Aug 28, 2024

Although I'm not happy about leaking some generated extended-lambda names, doing better would require properly integrating the system coverage check with the actual coverage checker, and while that may happen at the upcoming AIM, this is an easy-enough change to revert which prevents the reflection code from spitting nonsense at the user.

@plt-amy plt-amy merged commit 47c0bee into agda:master Aug 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants