Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isomorphisms between hSets, isUnivalent SET #734

Merged
merged 8 commits into from
Apr 9, 2022

Conversation

marcinjangrzybowski
Copy link
Contributor

No description provided.

Copy link
Collaborator

@mortberg mortberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small changes requested, then I would be happy to merge!

Cubical/Categories/Functor/Properties.agda Outdated Show resolved Hide resolved
Cubical/Foundations/Equiv/Properties.agda Outdated Show resolved Hide resolved
@marcinjangrzybowski
Copy link
Contributor Author

just saw bunch of similar things merged from one of the previous PRs, I will check if this still anything new in this PR

@mortberg
Copy link
Collaborator

mortberg commented Apr 4, 2022

just saw bunch of similar things merged from one of the previous PRs, I will check if this still anything new in this PR

Ok, I looked as well but didn't find anything. But I could possibly have missed something

@marcinjangrzybowski
Copy link
Contributor Author

Ok, I thought is saw some overlap with CommRing category is univalent and complete #694, but I think I was mistaken.

@mortberg
Copy link
Collaborator

mortberg commented Apr 4, 2022

Ok, I thought is saw some overlap with CommRing category is univalent and complete #694, but I think I was mistaken.

Yes, I thought so too because I could not remember what I had done in that PR... But I think it's all fine and there's no overlap

@mortberg mortberg merged commit ff1c817 into agda:master Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants