Dl sheaves properly ordered #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortberg
approved these changes
May 10, 2022
| module _ (x y : L .fst)where | ||
| hom-∨₁ : DLCat [ x , x ∨l y ] | ||
| hom-∨₁ = ∨≤RCancel _ _ | ||
| -- TODO: isn't the fixity of the operators a bit weird? |
There was a problem hiding this comment.
It's not clear to me what this comment is about?
There was a problem hiding this comment.
I gave meet and join the same fixity as both distribute over each other
| hom-∨₂ = ∨≤LCancel _ _ | ||
|
|
||
| hom-∧₁ : DLCat [ x ∧l y , x ] | ||
| hom-∧₁ = (≤m→≤j _ _ (∧≤RCancel _ _)) |
There was a problem hiding this comment.
No need for parenthesis in definition
| hom-∧₁ = (≤m→≤j _ _ (∧≤RCancel _ _)) | ||
|
|
||
| hom-∧₂ : DLCat [ x ∧l y , y ] | ||
| hom-∧₂ = (≤m→≤j _ _ (∧≤LCancel _ _)) |
There was a problem hiding this comment.
No need for parenthesis in definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the correct definition of sheaf on a basis of a distributive lattice. It doesn't contain any particularly interesting results yet (i.e. lifting to a sheaf on the whole lattice) but I thought I'll put it in the library before we start applying the new naming conventions everywhere.