Build cubical with latest Agda master (2022-05-09) #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2022
|
Build on 2.6.3 (of the merge commit for this PR) broken by: So, current |
|
Were we going to make a branch called Agda-dev that is kept up to date with Agda master? I have no clue how the CI works, so if someone can set up what Andreas suggests that would be great! Maybe @ecavallo knows how to do it? |
|
Yeah, I can have a go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed yesterday that the latest
cubicaldoes not build with the latestagda. This PR should fix this.IWinto a parameterIf you agree and merge this, the submodule pin for
cubicalin theagdarepo can be moved forward.On another note, it would be good if you would test
cubicalalso with the latestagda, just to get alerted of breakages. Maybe you can add such to your CI, using the deploys of Agda (https://github.com/agda/agda/actions/workflows/deploy.yml)