Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct sum and gradedRing #798

Merged
merged 89 commits into from
Jun 15, 2022
Merged

Direct sum and gradedRing #798

merged 89 commits into from
Jun 15, 2022

Conversation

thomas-lamiaux
Copy link
Contributor

@thomas-lamiaux thomas-lamiaux commented May 14, 2022

The goal of this PR has changed during the work. This is the updated message

Overview

The goal of this PR is to add a general notion graded ring.
This for two definitions of the direct sum that shown equivalent.

HIT Direct Sum

  • Add a pseudo normal form for the HIT direct sum if indexed by N
  • Add a proof that base is base k a = base l b => a = 0_k & b = 0_l for a decidable index
  • Add a universal property

Almost null sequences Direct Sum

  • Add another definition of the direct sum using almost null sequences
  • Prove the equivalence between the two definition of the direct sum if the index is N

Graded Ring

  • Add a general notion of graded ring using the HIT direct sum
  • Add some instances of gradedRing :
    • Trivial Graded Ring
    • Polynomial
    • Cohomology Ring
  • Replace the following constructions using the new graded ring construction
    • Polynomials
    • Cohomology Ring
  • Add the almost null sequences as an instance of the graded Ring when the index is a N monoid.
  • Add Instances using this new definition :
    • Polynomials
    • Cohomology Ring

@thomas-lamiaux
Copy link
Contributor Author

thomas-lamiaux commented May 19, 2022

I have proved that if can compute a normal form then the function is injective and so you have the equivalence !
This a huge progress because the data structure are mess here and this proof gives which data structures to use and how to use them.

I still have to add the some lemma on depVec and compute the normal form but now this should work.
By the way, The PR is currently a big mess.
This due to the complexity of all the data structures that makes really hard to prove things without trying a bunch of things and looking at the entire technical details.
Hence there is a lot of traces of past attempts and several naming convention coexisting due to past attempts.
This will be clean once the proof are completed.

Cubical/Algebra/CommRing/Base.agda Outdated Show resolved Hide resolved
Cubical/Algebra/CommRing/Instances/UnivariatePoly.agda Outdated Show resolved Hide resolved
Cubical/Algebra/CommRing/Instances/UnivariatePolyFun.agda Outdated Show resolved Hide resolved
Cubical/Algebra/DirectSum/DirectSumHIT/Properties.agda Outdated Show resolved Hide resolved
Cubical/Algebra/Ring/Properties.agda Outdated Show resolved Hide resolved
Cubical/Data/FinData/DepFinVec.agda Outdated Show resolved Hide resolved
Cubical/Data/Vec/DepVec.agda Outdated Show resolved Hide resolved
@thomas-lamiaux
Copy link
Contributor Author

@mortberg I have refactored Polynomials. Do you prefer the current

  • Multivariate
  • Univariate
    • UnivariateList
    • UnivariateFun
    • UnivariateHIT

Or would you prefer

  • Multivariate
  • Univariate
  • UnivariateList
  • UnivariateFun
  • UnivariateHIT

@thomas-lamiaux
Copy link
Contributor Author

I have fixed all issues except the bit of code that needs to be generalize that I will do by thursday.

@mortberg
Copy link
Collaborator

@mortberg I have refactored Polynomials. Do you prefer the current

* Multivariate

* Univariate

* * UnivariateList

* * UnivariateFun

* * UnivariateHIT

Or would you prefer

* Multivariate

* Univariate

* UnivariateList

* UnivariateFun

* UnivariateHIT

What is "Univariate" in the second suggestion? I think I prefer the flatter structure on matter what, there's already so much nesting.

@thomas-lamiaux
Copy link
Contributor Author

@mortberg you can consider it as done

@thomas-lamiaux thomas-lamiaux marked this pull request as ready for review June 14, 2022 22:27
@mortberg mortberg merged commit 5c22f5d into agda:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants