Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit files #102

Merged
merged 17 commits into from
Nov 1, 2020
Merged

Improve unit files #102

merged 17 commits into from
Nov 1, 2020

Conversation

sebschrader
Copy link
Member

  • Rename radius-vrrp to root-vrrp for consistency (all other VRRP instances are named like their namespace)
  • Order files consistently
  • Use Type=notify for unbound
  • Set RefuseManualStart for netns units, because they would automatically if not required anyway
  • Convert the hades target into service, so that it can be reloaded
  • Fix reference to non-existent hades-auth-dns.service unit

@sebschrader
Use Type=notify for unbound
8868b6f
@sebschrader
Order fields consistently
69e7e3f
@sebschrader
Fix reference to missing unit
056aa56
@sebschrader
Split dependencies into multiple lines
ecc9216
@sebschrader
Separate RuntimeDirectory properties
1bb1c6e
@sebschrader
Move PrivateNetwork before RuntimeDirectory
17f42e1
@sebschrader
Set RefuseManualStart for netns units
432ba40 
It doesn't make much sense to allow manual start of units, that
automatically stop when unneeded.
@sebschrader
Convert hades.target into a service
8840204 
Services can be reloaded and propagate the reload.
@sebschrader
Add missing article
61c94fa
@sebschrader
Remove transitive dependencies from hades.service
5b82cf9 
Only list dependencies, that would not be started automatically.
@sebschrader
Remove duplicate option
e9e1d3e
@sebschrader
Rename radius-vrrp to root-vrrp
17ea2ef 
The other VRRP instances are named after the corresponding namespace.
@sebschrader sebschrader added this to the 0.5 milestone Nov 1, 2020
@sebschrader sebschrader self-assigned this Nov 1, 2020
@sebschrader
Remove netns cleanup services
3af7b20 
The systemd bug has been fixed
@sebschrader
Convert inverse WantedBy via Also to direct Want
729a9de 
This is way simpler to understand. WantedBy doesn't give us any
benefits.
@sebschrader
Fix netns service inconsistencies
34275f9
@sebschrader
Teardown root netns in ExecStopPost
8ff2a68 
We should always forcefully teardown the root netns network settings,
otherwise the network might be left in an inconsistent state, where
subsequent ifup commands won't be able recover from without manual
operator intervention.
@sebschrader
Reset iptables in root netns in ExecStopPost
981e56c
@sebschrader sebschrader merged commit b6f8de4 into master Nov 1, 2020
@sebschrader sebschrader deleted the feature/unit-file-improvements branch July 6, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sebschrader sebschrader

Labels
bug enhancement hacktoberfest-accepted
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.
1 participant
@sebschrader