Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: weather endpoint #305

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

vitormcferreira
Copy link
Contributor

Describe your changes

Add a endpoint to generate random weather.

Link to issue this resolves

Closes #296.

Screenshot of changes(if relevant)

image

Copy link
Owner

@ageddesi ageddesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, just a few minor changes and will be ready to be merged

src/modules/weather/tests/api/weather-routes.test.ts Outdated Show resolved Hide resolved
src/modules/weather/utils/getWeather.ts Outdated Show resolved Hide resolved
src/modules/weather/utils/getWeather.ts Outdated Show resolved Hide resolved
src/modules/weather/api/weather-routes.ts Show resolved Hide resolved
src/modules/weather/api/weather-routes.ts Outdated Show resolved Hide resolved
@ageddesi
Copy link
Owner

ageddesi commented Feb 3, 2023

Hi @vitormcferreira Are you able to make the changes outstanding on this PR?

@ghost
Copy link

ghost commented Feb 3, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@vitormcferreira
Copy link
Contributor Author

Sorry for the delay in corrections.

I made the requested corrections and some code improvements.

@ageddesi ageddesi merged commit 580e2de into ageddesi:dev Mar 6, 2023
@ageddesi
Copy link
Owner

ageddesi commented Mar 6, 2023

Thank you @vitormcferreira for the changes and contributing to the project :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weather Endpoint
2 participants