Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vietnamese translation #44

Merged
merged 2 commits into from
Jan 20, 2017
Merged

Add Vietnamese translation #44

merged 2 commits into from
Jan 20, 2017

Conversation

J2TEAM
Copy link
Contributor

@J2TEAM J2TEAM commented Jan 20, 2017

No description provided.

@ageitgey ageitgey mentioned this pull request Jan 20, 2017
Closed
@ageitgey
Copy link
Owner

Should I merge this one or #43 ?

@J2TEAM
Copy link
Contributor Author

J2TEAM commented Jan 20, 2017

@ageitgey I think my PR is better. Why?

https://github.com/narutoo9x/show-facebook-computer-vision-tags/blob/master/locales/vi_VN/messages.json#L26

He translated "dessert" is "sa mạc" ("desert" in English).

@ageitgey ageitgey merged commit 04d68a9 into ageitgey:master Jan 20, 2017
@J2TEAM J2TEAM deleted the vietnamese branch January 20, 2017 19:41
@narutoo9x
Copy link

My #43 is not good as this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@J2TEAM @ageitgey @narutoo9x