Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unique fields bugfix #341

Merged
merged 2 commits into from
Jul 17, 2015
Merged

Unique fields bugfix #341

merged 2 commits into from
Jul 17, 2015

Conversation

piotr-cz
Copy link
Contributor

I found few problems with my PR #338.

  • code wasn't checking for uniqueness of field's slug (but of the field value itself).
  • when looking for conflicts, code didn't ignore it's own object, so it was not possible to save entries keeping same slug.
  • in error message I've changed the display name to label, as this is what user sees in the edit form.

aheinze added a commit that referenced this pull request Jul 17, 2015
@aheinze
Merge pull request #341 from piotr-cz/fix-Unique_fields
7fc70e5 
Unique fields bugfix
@aheinze aheinze merged commit 7fc70e5 into agentejo:master Jul 17, 2015
@piotr-cz piotr-cz deleted the fix-Unique_fields branch August 3, 2015 08:05
@piotr-cz piotr-cz mentioned this pull request Feb 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@piotr-cz @aheinze