Option to set google masp API key (Cockpit-Master) #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
I was wondering this should go to the Settings/ General or Api Access. |
|
right ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in this announcement, Google Maps requires using API key for domains active after 22/06/2016 and localhost domain.
Without it, widget doesn't render and console shows a
MissingKeyMapError.I've added new tab: Settings > General > Google Maps to have add an ability to specify the API key.
Data is stored under collection
cockpit/settingsand keycockpit.gmaps.key.This PR concerns (old/ master) Cockpit branch, possibly similar implementation may be prepared for Cockpit Next (effort started here)