Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified calculation of message injection point minutes to be able to… #58

Merged
merged 4 commits into from
Feb 11, 2024

Conversation

gwehr1
Copy link
Collaborator

@gwehr1 gwehr1 commented Jan 16, 2024

… handle multi-day messaging

@gwehr1 gwehr1 requested a review from dhixsingh January 16, 2024 01:22
@dhixsingh
Copy link
Contributor

Can we update one of the tests to use the multi-day format so this is always checked for?

…IM global CRS instead, so that the transform of trips into EPSG:4326 in the class works correctly.
@gwehr1
Copy link
Collaborator Author

gwehr1 commented Feb 1, 2024

Yes an existing test could be quite easily modified to test this in future. It would require a) changing the timing of the last message, b) extending the endTime param in the matsim config.xml to match, and c) changing the plans.xml.gz file to extend the default activity end time beyond 23:59:59 to match

@dhixsingh
Copy link
Contributor

Would be good to do that now. The scenario in https://github.com/agentsoz/ees/tree/main/ees/scenarios/mount-alexander-shire/campbells-creek-1 has a single agent so easy enough to adjust. I would also enable the DeckGL output and add a check that compares it to an expected output. Let me know if you are ok to do that else assign it to me.

@gwehr1
Copy link
Collaborator Author

gwehr1 commented Feb 1, 2024

Happy to give it a go, will let you know if I run into issues.

…ulti-day disruptions, and check the DeckGL output
@dhixsingh dhixsingh merged commit d3b1911 into dev Feb 11, 2024
2 checks passed
@dhixsingh dhixsingh deleted the fix-multi-day-messaging branch February 11, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants