Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 8: Clarify some comments and remove unnecessary ones, fix typo #18

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

vi3itor
Copy link
Contributor

@vi3itor vi3itor commented Jun 14, 2022

Hi @ageron,

Please find some fixes for the Chapter 8 notebook. For one of such fixes, the diff below doesn't show that the comment "Recover the 3D points projected on the plane (PCA 2D subspace)." is not followed by any code in the third edition and might be confusing (it was relevant in the previous edition). Moreover, there is an example of how to recover the points later in the notebook.
Other edits are self-explanatory :)

@ageron ageron merged commit eabcc49 into ageron:main Jun 15, 2022
@ageron
Copy link
Owner

ageron commented Jun 15, 2022

Thanks a lot, @vi3itor ! 😊👍

@vi3itor vi3itor deleted the ch8-errata branch June 15, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants