-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MCP3008 ADC overlay #1052
Add MCP3008 ADC overlay #1052
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Didn’t go through? Hmm, works for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @jclsn. You missed the SoB (signed off by line) and also I'd tweak a bit the commit subject: rpi-base.inc: Add MCP3008 ADC overlay
.
I have included this change in #1053. Closing. |
@agherzan Ah, did not know about the SoB. Will try to remember it next time! Lately I have been getting this error
No idea what I did, but somehow it can't add the blob to the image anymore. Any idea why? |
What machine are you building for and what revisions of the layers? EDIT: Checking the logs, you are building for rpi4-64. What about the revision of the layers? Are you sure you have the kernel updated so that the dts exists? |
I think I found the issue. The above error only occurs when I explicitly append the blob to I also have an issue with creating my own image. The splash screen is gone, although it is listed in |
This adds the overlay for the MCP3008 ADC.