Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MCP3008 ADC overlay #1052

Closed
wants to merge 1 commit into from
Closed

Add MCP3008 ADC overlay #1052

wants to merge 1 commit into from

Conversation

jclsn
Copy link

@jclsn jclsn commented Apr 15, 2022

This adds the overlay for the MCP3008 ADC.

Copy link
Collaborator

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jclsn
Copy link
Author

jclsn commented Apr 16, 2022

Didn’t go through? Hmm, works for me

Copy link
Owner

@agherzan agherzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @jclsn. You missed the SoB (signed off by line) and also I'd tweak a bit the commit subject: rpi-base.inc: Add MCP3008 ADC overlay.

@agherzan
Copy link
Owner

I have included this change in #1053. Closing.

@agherzan agherzan closed this Apr 21, 2022
@jclsn
Copy link
Author

jclsn commented May 27, 2022

@agherzan Ah, did not know about the SoB. Will try to remember it next time!

Lately I have been getting this error

ERROR: healthpi-image-1.0-r0 do_image_rpi_sdimg: mcopy cannot copy /home/claussenj/Workspace/Yocto/healthpi/build/tmp/deploy/images/raspberrypi4-64/mcp3008.dtbo into boot.img
ERROR: healthpi-image-1.0-r0 do_image_rpi_sdimg: ExecutionError('/home/claussenj/Workspace/Yocto/healthpi/build/tmp/work/raspberrypi4_64-poky-linux/healthpi-image/1.0-r0/temp/run.do_image_rpi_sdimg.802539', 1, None, None)
ERROR: Logfile of failure stored in: /home/claussenj/Workspace/Yocto/healthpi/build/tmp/work/raspberrypi4_64-poky-linux/healthpi-image/1.0-r0/temp/log.do_image_rpi_sdimg.802539
ERROR: Task (/home/claussenj/Workspace/Yocto/healthpi/sources/meta-healthpi/recipes-healthpi/images/healthpi-image.bb:do_image_rpi_sdimg) failed with exit code '1

No idea what I did, but somehow it can't add the blob to the image anymore. Any idea why?

@agherzan
Copy link
Owner

agherzan commented May 28, 2022

What machine are you building for and what revisions of the layers?

EDIT: Checking the logs, you are building for rpi4-64. What about the revision of the layers? Are you sure you have the kernel updated so that the dts exists?

@jclsn
Copy link
Author

jclsn commented May 28, 2022

I think I found the issue. The above error only occurs when I explicitly append the blob to RPI_KERNEL_DEVICETREE_OVERLAYS. When I remove that line from my ``local.conf```it works. I wonder why though. Like this it is in there twice, but that shouldn't make a difference from my understanding.

I also have an issue with creating my own image. The splash screen is gone, although it is listed in SPLASH. Can I get support from you on this? It is not part of this topic. I also have another issue regarding libGL again, although I thought that I fixed it. Been trying for weeks to get my project to work on the Pi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants