Update python3-adafruit-blinka_6.2.2.bb #1301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disabled qa, to allow shipping 32bit binaries also in a 64bit rpi machines
agherzan
requested changes
Mar 27, 2024
There was a problem hiding this comment.
Also, please note https://meta-raspberrypi.readthedocs.io/en/latest/contributing.html on the expectations of git log format (for example). Thanks!
dynamic-layers/openembedded-layer/recipes-devtools/python/python3-adafruit-blinka_6.2.2.bb
Outdated
Show resolved
Hide resolved
…ries in 64 bit rpi machines foobar: Update python3-adafruit-blinka_6.2.2.bb to allow shipping 32 bit binaries in 64 bit rpi machines When building for a 64bit architecture, this recipes does not ships 32bit binaries, that would be fully compatible anyway. To resolve this issue, it's been changed the permissions to 0644 to this binaries Signed-off-by: Gianluca Iaia <gianluca.iaia@engynya.com>
python3-adafruit-blinka: Update recipe to allow shipping 32bit binaries in 64bit machines When building for a 64bit architecture, this recipes does not ships 32bit binaries, that would be fully compatible anyway. To resolve this issue, it's been changed the permissions to 0644 to this binaries Signed-off-by: Gianluca Iaia <gianluca.iaia@engynya.com>
iaiagianluca
commented
Apr 2, 2024
agherzan
requested changes
Apr 29, 2024
There was a problem hiding this comment.
This MR needs some cleanup:
- squash things in one commits
- rebase to drop merge commits
- have a clear git log rationale of what and why
- adhere to https://meta-raspberrypi.readthedocs.io/en/latest/contributing.html (for example line length recommendation in git log)
Once again, thanks for your contribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disabled qa, to allow shipping 32bit binaries also in a 64bit rpi machines