omxplayer: make samba support configureable #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* samba depends on libpam and it might be useful to disable support for it in DISTROs without pam in DISTRO_FEATURES * disable it by default Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
agherzan
approved these changes
Feb 1, 2018
|
Looks good. Thanks @shr-project |
halstead
pushed a commit
to openembedded/openembedded-core
that referenced
this pull request
Mar 3, 2018
* replace do_pam_sanity function with distro_features_check inherit * fixes: WARNING: libpam-1.3.0-r5 do_pam_sanity: Building libpam but 'pam' isn't in DISTRO_FEATURES, PAM won't work correctly in world builds and prevents user to build libpam at all without pam in DISTRO_FEATURES, I don't see any users of this which wouldn't respect pam in DISTRO_FEATURES * only libuser is depending on libpam without respecting DISTRO_FEATURES * there are few recipes in meta-oe layers depending on libpam without respecting DISTRO_FEATURES, I've sent patch for them: samba, openwsman, pam-ssh-agent-auth, sblim-sfcb, passwdqc, python-pam, smbnetfs and omxplayer in meta-raspberrypi, I've sent PR for that one: agherzan/meta-raspberrypi#192 * poky-lsb will need to add pam to DISTRO_FEATURES in order to build packagegroup-core-lsb Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
gbionescu
pushed a commit
to gbionescu/poky
that referenced
this pull request
Mar 3, 2018
* replace do_pam_sanity function with distro_features_check inherit * fixes: WARNING: libpam-1.3.0-r5 do_pam_sanity: Building libpam but 'pam' isn't in DISTRO_FEATURES, PAM won't work correctly in world builds and prevents user to build libpam at all without pam in DISTRO_FEATURES, I don't see any users of this which wouldn't respect pam in DISTRO_FEATURES * only libuser is depending on libpam without respecting DISTRO_FEATURES * there are few recipes in meta-oe layers depending on libpam without respecting DISTRO_FEATURES, I've sent patch for them: samba, openwsman, pam-ssh-agent-auth, sblim-sfcb, passwdqc, python-pam, smbnetfs and omxplayer in meta-raspberrypi, I've sent PR for that one: agherzan/meta-raspberrypi#192 * poky-lsb will need to add pam to DISTRO_FEATURES in order to build packagegroup-core-lsb (From OE-Core rev: 7d05eb3b6dac2ec7711abb6ce6f3e772636aa8dc) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
gbionescu
pushed a commit
to gbionescu/poky
that referenced
this pull request
Mar 3, 2018
* replace do_pam_sanity function with distro_features_check inherit * fixes: WARNING: libpam-1.3.0-r5 do_pam_sanity: Building libpam but 'pam' isn't in DISTRO_FEATURES, PAM won't work correctly in world builds and prevents user to build libpam at all without pam in DISTRO_FEATURES, I don't see any users of this which wouldn't respect pam in DISTRO_FEATURES * only libuser is depending on libpam without respecting DISTRO_FEATURES * there are few recipes in meta-oe layers depending on libpam without respecting DISTRO_FEATURES, I've sent patch for them: samba, openwsman, pam-ssh-agent-auth, sblim-sfcb, passwdqc, python-pam, smbnetfs and omxplayer in meta-raspberrypi, I've sent PR for that one: agherzan/meta-raspberrypi#192 * poky-lsb will need to add pam to DISTRO_FEATURES in order to build packagegroup-core-lsb (From OE-Core rev: 7d05eb3b6dac2ec7711abb6ce6f3e772636aa8dc) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead
pushed a commit
to openembedded/openembedded-core
that referenced
this pull request
Mar 3, 2018
* replace do_pam_sanity function with distro_features_check inherit * fixes: WARNING: libpam-1.3.0-r5 do_pam_sanity: Building libpam but 'pam' isn't in DISTRO_FEATURES, PAM won't work correctly in world builds and prevents user to build libpam at all without pam in DISTRO_FEATURES, I don't see any users of this which wouldn't respect pam in DISTRO_FEATURES * only libuser is depending on libpam without respecting DISTRO_FEATURES * there are few recipes in meta-oe layers depending on libpam without respecting DISTRO_FEATURES, I've sent patch for them: samba, openwsman, pam-ssh-agent-auth, sblim-sfcb, passwdqc, python-pam, smbnetfs and omxplayer in meta-raspberrypi, I've sent PR for that one: agherzan/meta-raspberrypi#192 * poky-lsb will need to add pam to DISTRO_FEATURES in order to build packagegroup-core-lsb Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
gbionescu
pushed a commit
to gbionescu/poky
that referenced
this pull request
Mar 3, 2018
* replace do_pam_sanity function with distro_features_check inherit * fixes: WARNING: libpam-1.3.0-r5 do_pam_sanity: Building libpam but 'pam' isn't in DISTRO_FEATURES, PAM won't work correctly in world builds and prevents user to build libpam at all without pam in DISTRO_FEATURES, I don't see any users of this which wouldn't respect pam in DISTRO_FEATURES * only libuser is depending on libpam without respecting DISTRO_FEATURES * there are few recipes in meta-oe layers depending on libpam without respecting DISTRO_FEATURES, I've sent patch for them: samba, openwsman, pam-ssh-agent-auth, sblim-sfcb, passwdqc, python-pam, smbnetfs and omxplayer in meta-raspberrypi, I've sent PR for that one: agherzan/meta-raspberrypi#192 * poky-lsb will need to add pam to DISTRO_FEATURES in order to build packagegroup-core-lsb (From OE-Core rev: c9e7a276859d38aaa03845ee09428f62760ad147) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
gbionescu
pushed a commit
to gbionescu/poky
that referenced
this pull request
Mar 4, 2018
* replace do_pam_sanity function with distro_features_check inherit * fixes: WARNING: libpam-1.3.0-r5 do_pam_sanity: Building libpam but 'pam' isn't in DISTRO_FEATURES, PAM won't work correctly in world builds and prevents user to build libpam at all without pam in DISTRO_FEATURES, I don't see any users of this which wouldn't respect pam in DISTRO_FEATURES * only libuser is depending on libpam without respecting DISTRO_FEATURES * there are few recipes in meta-oe layers depending on libpam without respecting DISTRO_FEATURES, I've sent patch for them: samba, openwsman, pam-ssh-agent-auth, sblim-sfcb, passwdqc, python-pam, smbnetfs and omxplayer in meta-raspberrypi, I've sent PR for that one: agherzan/meta-raspberrypi#192 * poky-lsb will need to add pam to DISTRO_FEATURES in order to build packagegroup-core-lsb (From OE-Core rev: c9e7a276859d38aaa03845ee09428f62760ad147) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.