linux-firmware: fix addition of NVRAM file to image (fixes #184) #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hugo Hromic <hhromic@gmail.com>
|
Amended the commit log message. Thanks @agherzan ! |
|
Can one of the admins verify this patch? |
|
thanks for doing this. |
|
ok to test |
agherzan
approved these changes
Feb 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #184, where the Wifi module is not brought up because of missing firmware file.
- What I did
The NVRAM text file for the BCM firmware was not properly added in the built image. This is because the recipe
recipes-kernel/linux-firmware/linux-firmware_%.bbappendis using+=for adding the extra file instead of_appendinFILES_${PN}-bcm43430.This results in only the NVRAM text file being added to the built image and not the firmware binary file (
.bin), causing the Wifi module to not work.I tested the images also enabling the bluetooth module (as discussed in #184) to ensure this doesn't interfere with other connectivity components.
After this fix, both files (
.txtand.bin) of the firmware are now correctly installed in/lib/firmware.- How I did it
I simply replaced the
+=construction with an_appendconstruction as seen in the PR.