New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RasperryPi 3B+ support #215

Merged
merged 10 commits into from Apr 3, 2018

Conversation

Projects
None yet
6 participants
@agherzan
Owner

agherzan commented Mar 28, 2018

- What I did
Packages updates needed for RasperryPi 3B+ support (and some kernel updates)

agherzan added some commits Mar 28, 2018

linux-raspberrypi: Update 4.9 recipe to current HEAD
Signed-off-by: Andrei Gherzan <andrei@gherzan.com>
linux-raspberrypi: Update 4.14 recipe to 4.14.30
Signed-off-by: Andrei Gherzan <andrei@gherzan.com>
firmware: Update to 20180313
Signed-off-by: Andrei Gherzan <andrei@gherzan.com>

@agherzan agherzan self-assigned this Mar 28, 2018

@agherzan agherzan requested a review from paul-betafive Mar 28, 2018

@kraj

I think the name is quite confusing, since the firmware blobs generally are non-free even from original package.

You should be able to write PREFERRED_PROVIDER mechanism to choose one over other and may be call is linux-firmware-raspbian

@agherzan

This comment has been minimized.

Owner

agherzan commented Mar 28, 2018

@kraj good point on naming. I actually thought to go with the PREFERRED_PROVIDER but I just didn't want to maintain all the other packages that come with the linux-firmware package. Basically just wanted two firmware as they are used by RPI. And this simplified a lot the recipe.

@kraj

This comment has been minimized.

Collaborator

kraj commented Mar 28, 2018

@agherzan I think people using extra HATS might need extra firmware no ?

@agherzan

This comment has been minimized.

Owner

agherzan commented Mar 28, 2018

@kraj Exactly. They will use the ones from linux-firmware for everything but the integrated wifi firmware that will be provided by the raspbian repository.

@paul-betafive

This comment has been minimized.

Collaborator

paul-betafive commented Mar 28, 2018

I share @kraj's concern about the name. linux-firmware-raspbian would be much clearer.

I don't think we need to worry about packaging everything from the Raspbian firmware repository right now though. If there are extra things needed for various hats we can add them to the recipe later.

Other than that, all looks good.

@Kostia-K

This comment has been minimized.

Kostia-K commented Mar 28, 2018

I believe you also need to add bcm2710-rpi-3-b-plus.dtb to KERNEL_DEVICETREE in rpi-base.inc

@agherzan

This comment has been minimized.

Owner

agherzan commented Mar 28, 2018

What? They have a new dt? Good catch @Kostia-K. I'll take a look.

agherzan added some commits Mar 28, 2018

linux-firmware-raspbian: New recipe which uses RPi-Distro repository
This packages only the firmware needed for the RaspberryPi boards. We use the
RPi-Distro as it's already maintained by the Raspbian guys and we get better
support for the RaspberryPi needed firmwares.

Signed-off-by: Andrei Gherzan <andrei@gherzan.com>
raspberrypi3.conf: Use linux-firmware-raspbian packages and add bcm43455
Signed-off-by: Andrei Gherzan <andrei@gherzan.com>
raspberrypi3-64.conf: Use linux-firmware-raspbian packages and add bc…
…m43455

Signed-off-by: Andrei Gherzan <andrei@gherzan.com>
rpi-base.inc: Add Raspberry Pi 3B+ dtb
Signed-off-by: Andrei Gherzan <andrei@gherzan.com>
@agherzan

This comment has been minimized.

Owner

agherzan commented Mar 29, 2018

@Kostia-K @kraj @betafive Renamed the recipe, added the rpi3b+ dtb, retested, all good.

@hhromic

This comment has been minimized.

Contributor

hhromic commented Mar 29, 2018

Hi ! Thanks for the update!
Should the linux-firmware-raspbian new package be used also for the raspberrypi0-wifi.conf config file aswell? The RPI0W also comes with Wifi/BT onboard.

@hhromic

This comment has been minimized.

Contributor

hhromic commented Mar 29, 2018

Also, this new linux-firmware-raspbian recipe renders the existing linux-firmware recipe obsolete? e.g. should be removed?

https://github.com/agherzan/meta-raspberrypi/tree/master/recipes-kernel/linux-firmware

@agherzan

This comment has been minimized.

Owner

agherzan commented Mar 29, 2018

@hhromic I just left it there for now to not break people's work. If they use linux-firmware they will still get the same blobs. I was tempted to remove them at first.

@hhromic

This comment has been minimized.

Contributor

hhromic commented Mar 29, 2018

Good point.
For the rocko branch I agree 100% it should be kept.
However, this PR is for the master branch, which is expected to be bleeding edge and should not contain deprecated things that in the end turn into more maintenance effort for lazy users that do not read the documentation.
This change should be documented. If you remember from #184, it was not clear that the firmware has to be explicitly included. In this case the documentation should say that "if you want Wifi/BT you must include linux-firmware-raspbian.

agherzan added some commits Mar 29, 2018

raspberrypi0-wifi.conf: Use linux-firmware-raspbian package
Signed-off-by: Andrei Gherzan <andrei@gherzan.com>
linux-firmware: Remove as replaced by linux-firmware-raspbian
Signed-off-by: Andrei Gherzan <andrei@gherzan.com>
layer-contents.md: Update documentation
* Raspberry Pi 3B+ support mentioned
* Add info about linux-firmware-raspbian

Signed-off-by: Andrei Gherzan <andrei@gherzan.com>
@agherzan

This comment has been minimized.

Owner

agherzan commented Mar 29, 2018

@hhromic agreed. Pushed changed to address documentation and removal of linux-firmware bits.

@kraj

This comment has been minimized.

Collaborator

kraj commented Mar 29, 2018

Looks good

@paul-betafive paul-betafive merged commit 292e000 into master Apr 3, 2018

4 checks passed

Build pull request All "basic" raspberries were happy
Details
raspberrypi1 I baked a happy raspberry
Details
raspberrypi2 I baked a happy raspberry
Details
raspberrypi3 I baked a happy raspberry
Details

@agherzan agherzan deleted the ag_rpi3bplus branch Apr 3, 2018

@davidweisgerber

This comment has been minimized.

davidweisgerber commented Apr 25, 2018

Will this be backported to morty?

@agherzan

This comment has been minimized.

Owner

agherzan commented Apr 25, 2018

There are no plans as far as I am aware of this point. We would not reject patches though.

@paul-betafive

This comment has been minimized.

Collaborator

paul-betafive commented Apr 25, 2018

Morty currently defaults to the 4.4 kernel series which won't support RPi 3 B+. The recipe for the 4.9 series kernel and the firmware are also pretty far behind and would need a lot of updates to support that device. From previous testing I'm pretty sure the firmware updates break compatibility with the 4.4 series kernels and so that's probably not a good avenue to go down.

I'd recommend trying out master or the backports for rocko which I've just posted (PR #229).

@agherzan

This comment has been minimized.

Owner

agherzan commented Apr 25, 2018

Good point.

@hhromic

This comment has been minimized.

Contributor

hhromic commented Apr 25, 2018

I would also like to add that even officially from the Raspberry Pi Foundation, the RPi 3B+ is supported since Raspbian Stretch (Kernel 4.14) and not Jessie (Kernel 4.9). Meaning that is much less effort to maintain with Kernel 4.14 than anything below.
@davidweisgerber , maybe is a much better value for your effort to migrate to Rocko+ than to backport this layer to Morty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment