add support for parameterize redirected resources due to trailing slash #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
laughingman-hass
force-pushed
the
hass/2293-trail-slash-redirects
branch
2 times, most recently
from
90ffcfb
to
846be8e
Compare
|
Looks good to me! Thanks for adding the tests! 🙌 |
devillecodes
approved these changes
Nov 1, 2023
If a redirect is detected due to a trailing slash, look up the parameters for the route without the trailing slash and use that for the parameterization
Co-authored-by: Katie Hockman <katie@hockman.dev>
Co-authored-by: Katie Hockman <katie@hockman.dev>
laughingman-hass
force-pushed
the
hass/2293-trail-slash-redirects
branch
from
62921de
to
302054a
Compare
|
closing as PR upstream has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for routes that contain a trailing slash which result in a redirect. If a redirect is detected due to a trailing slash, look up the parameters for the route without the trailing slash and use that for the parameterization
Motivation
Bug raised on upstream repo DataDog#2293
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!