Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type generation for IDM 7 #13

Merged
merged 7 commits into from
Jul 26, 2021
Merged

Fix type generation for IDM 7 #13

merged 7 commits into from
Jul 26, 2021

Conversation

pearj
Copy link
Collaborator

@pearj pearj commented Jul 22, 2021

This fixes type generation for IDM 7, where the authzRoles relationship only refers to an internal/role which we don't have TypeScript types for yet. In that case it just falls back to Record<string,any> when it can't find the relevant relationship type.

At the same type I have converted this to use semantic-release so that commits to master automatically release changes (provided the commit message is in the right format).

Prettier has also been updated as it was failing due to it using an older TypeScript version.

* Fixes an issue where prettier couldn't format query-filter.ts due to a newer typescript version
* This fixes ManagedUser->authzRoles which in IDM 7 only uses
internal/role, which we don't generate types for at present.
* incorporate dependabot changes
* Update contributors
* Switch workflow badge to the github one
@pearj pearj requested a review from dbalmain July 22, 2021 03:39
@dspasojevic
Copy link
Member

@pearj how do you feel about hooking semver up with commitzen so that we get dependable commit messages as part of this change as well?

@pearj pearj requested review from dspasojevic and removed request for danielnixon July 22, 2021 12:59
@pearj
Copy link
Collaborator Author

pearj commented Jul 22, 2021

@pearj how do you feel about hooking semver up with commitzen so that we get dependable commit messages as part of this change as well?

That sounds like a good idea, I have done that.

@pearj pearj merged commit 01fc499 into agiledigital:master Jul 26, 2021
@pearj pearj deleted the idm7fixes branch July 26, 2021 00:02
@github-actions
Copy link

🎉 This PR is included in version 1.0.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants