feature: Implement hasOne relation (issue #6) #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review this PR and let me know if something needs to be changed @nicoabie |
nicoabie
requested changes
Nov 18, 2023
src/assemble.test.ts
Outdated
Comment on lines
71
to
89
| test('assemble hasOne', () => { | ||
| const objects = [{ 'p.personId': 1 }, { 'p.personId': 2 }]; | ||
|
|
||
| const relations: Relations = { | ||
| person: { | ||
| contact: ['hasOne', 'contactDetails'], | ||
| }, | ||
| }; | ||
| const aliases = { | ||
| p: 'person', | ||
| c: 'contact', | ||
| }; | ||
| const identifiers = ['p.personId', 'c.contactId']; | ||
|
|
||
| assert.deepStrictEqual(assemble(relations, aliases, identifiers, objects), [ | ||
| { personId: 1 }, | ||
| { personId: 2 }, | ||
| ]); | ||
| }); |
There was a problem hiding this comment.
is this a valid test case? I don't think the database is going to give that output
src/assemble.test.ts
Outdated
Comment on lines
136
to
163
| test('assemble hasOne relationship with complex data', () => { | ||
| const objects = [ | ||
| { 'p.personId': 1, 'c.contactId': 101 }, | ||
| { 'p.personId': 2, 'c.contactId': null }, | ||
| { 'p.personId': 3, 'c.contactId': 101 }, | ||
| { 'p.personId': 4, 'c.contactId': 103 }, | ||
| { 'p.personId': 5 }, | ||
| ]; | ||
|
|
||
| const relations: Relations = { | ||
| person: { | ||
| contact: ['hasOne', 'contactDetails'], | ||
| }, | ||
| }; | ||
| const aliases = { | ||
| p: 'person', | ||
| c: 'contact', | ||
| }; | ||
| const identifiers = ['p.personId', 'c.contactId']; | ||
|
|
||
| assert.deepStrictEqual(assemble(relations, aliases, identifiers, objects), [ | ||
| { personId: 1 }, | ||
| { personId: 2 }, | ||
| { personId: 3 }, | ||
| { personId: 4, contactDetails: { contactId: 103 } }, | ||
| { personId: 5 }, | ||
| ]); | ||
| }); |
There was a problem hiding this comment.
I don't think this is correct.
- the database will return something for person 5, see my previous comment
- person 1 and 3 point to the same object and that is fine from a strict point of view
src/assemble.ts
Outdated
| @@ -77,6 +78,19 @@ export const assemble: AssembleFn = <T>( | |||
| if (child[childIdentifier.split('.')[1]] !== null) { | |||
| parent[parentChildRelation[1]].push(child); | |||
| } | |||
| } else if (parentChildRelation[0] === 'hasOne') { | |||
| if (child[childIdentifier.split('.')[1]] !== null) { | |||
There was a problem hiding this comment.
maybe we should put childIdentifier.split('.')[1] in a variable as it is being calculated 4 times
ofcoure!! no worries, and no i don't think i have permission to request the review |
nicoabie
reviewed
Nov 18, 2023
src/assemble.test.ts
Outdated
|
|
||
| assert.deepStrictEqual(assemble(relations, aliases, identifiers, objects), [ | ||
| { personId: 1, contactDetails: { contactId: 101 } }, | ||
| { personId: 2 }, |
There was a problem hiding this comment.
in this case contactDetails should be null
{ personId: 2, contactDetails: null },
src/assemble.test.ts
Outdated
Comment on lines
117
to
142
| test('assemble hasOne relationship with complex data', () => { | ||
| const objects = [ | ||
| { 'p.personId': 1, 'c.contactId': 101 }, | ||
| { 'p.personId': 2, 'c.contactId': null }, | ||
| { 'p.personId': 3, 'c.contactId': 101 }, | ||
| { 'p.personId': 4, 'c.contactId': 103 }, | ||
| ]; | ||
|
|
||
| const relations: Relations = { | ||
| person: { | ||
| contact: ['hasOne', 'contactDetails'], | ||
| }, | ||
| }; | ||
| const aliases = { | ||
| p: 'person', | ||
| c: 'contact', | ||
| }; | ||
| const identifiers = ['p.personId', 'c.contactId']; | ||
|
|
||
| assert.deepStrictEqual(assemble(relations, aliases, identifiers, objects), [ | ||
| { personId: 1 }, | ||
| { personId: 2 }, | ||
| { personId: 3 }, | ||
| { personId: 4, contactDetails: { contactId: 103 } }, | ||
| ]); | ||
| }); |
nicoabie
approved these changes
Nov 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement hasOne relation for issue #6