v0.3.0 - Indicate new unread chapters #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
force-pushed
the
indicate-new-unread-chapters
branch
from
62f0424
to
49eb049
Compare
agilgur5
commented
Nov 22, 2019
There was a problem hiding this comment.
Only a few small, minimal changes, looks ok!
There are some questions around whether isNew and newText should be MST views, but I think this is fine for now and we can refactor later if necessary.
Going to let this sit a bit so I can test it with real usage / data for a bit before releasing
- so one can tell at a glance if there's a chapter they haven't read
without having to tap into the manga
- highlight # of new unread chapters in white
- make Manga component an observer so changes to the chapter list
actually update the view
- continue showing "Today" or "Yesterday" if it's in the latest section
- this # replaces that only if it's available, which, for most cases,
means only for favorites, as those are the only ones persisted
- but if one tapped into a latest, it would start showing # there
as well
- increase the font size a bit since # isn't uppercased and therefore
is harder to see than a "TODAY"
agilgur5
force-pushed
the
indicate-new-unread-chapters
branch
from
49eb049
to
165e1d6
Compare
agilgur5
changed the title
- so if any new chapters were released since you last opened the app,
it will update immediately and indicate if there are any new unread
chapters as of just now
- prev would only show new unread chapters since the last time you
clicked into the manga, which was bound to be out-of-date
- other than multiple providers, this is the last big, must-have
feature I really needed to make me consistently return & use this
app instead of others
- others are more "nice-to-have" or "very-nice-to-have", but not
necessarily dealbreakers for me at least
- adds text displaying # of new unread chapters per manga at-a-glance in main manga list view - adds logic to fetch chapters for all favorited manga on app load, ensuring up-to-date # of new unread chapters for each - both additions help give users visibility into if there are any new chapters to read without having to tap into the manga
agilgur5
force-pushed
the
indicate-new-unread-chapters
branch
from
e4aa938
to
82b8d57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is like the MVP / first phase of #18 . After this, now that we have indicators in-app and fetch chapters on app load, we can move on to fetching in background and having notifications out-of-app.