Skip to content
This repository has been archived by the owner on May 26, 2021. It is now read-only.

Made IndexMatcher reusable #200

Merged
merged 2 commits into from
Feb 4, 2020
Merged

Made IndexMatcher reusable #200

merged 2 commits into from
Feb 4, 2020

Conversation

yapkolotilov
Copy link
Contributor

Read issue for details

@claassistantio
Copy link

claassistantio commented Jan 31, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@Unlimity
Copy link
Member

Close: #199

Unlimity
Unlimity approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@Unlimity Unlimity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also alter the documentation in the builder function that uses this matcher?

@yapkolotilov
Copy link
Contributor Author

Sorry, guys, I'm not familiar with GitHub pull request workflow. In com.agoda.kakao.common.builders.ViewBuilder just paste this above withIndex:

     /**
     * Matches only view at given [index], if there are multiple views that matches
     *
     * @param index Index of the view to match
     * @param function [ViewBuilder] that will result in matcher
     */

@Unlimity
Copy link
Member

You can just make the change and push it to your branch

@Unlimity
Copy link
Member

No worries, updated it for you 👍

@Vacxe
Copy link
Member

Vacxe commented Jan 31, 2020

@yapkolotilov thanks for the contribution mate!

@Vacxe
Copy link
Member

Vacxe commented Jan 31, 2020

@yapkolotilov also please sign the CLA. Just tap here under licence/cla task.

@Vacxe Vacxe merged commit d50f14e into agoda-com:master Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Vacxe Vacxe Vacxe approved these changes

@Unlimity Unlimity Unlimity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yapkolotilov @claassistantio @Unlimity @Vacxe