Fixes build failure with GCC6 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, libgtextutils fails to build with GCC6 [1]. See [2] for further details. [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=811646 [2] https://gcc.gnu.org/gcc-6/porting_to.html
hartzell
pushed a commit
to hartzell/spack
that referenced
this pull request
Mar 9, 2017
The issue is described in depth [here][desc]. C++14 no longer allows implicit conversion from iostream classes to void*. This patch comes directly from [PR spack#6][patch]. [desc]: http://stackoverflow.com/questions/38659115/make-fails-with-error-cannot-convert-stdistream-aka-stdbasic-istreamchar [patch]: agordon/libgtextutils#6
adamjstewart
pushed a commit
to spack/spack
that referenced
this pull request
Mar 9, 2017
* New gcc uses C++14 mode, this fixes implicit conversion The issue is described in depth [here][desc]. C++14 no longer allows implicit conversion from iostream classes to void*. This patch comes directly from [PR #6][patch]. [desc]: http://stackoverflow.com/questions/38659115/make-fails-with-error-cannot-convert-stdistream-aka-stdbasic-istreamchar [patch]: agordon/libgtextutils#6 * mend
diaena
pushed a commit
to diaena/spack
that referenced
this pull request
May 26, 2017
* New gcc uses C++14 mode, this fixes implicit conversion The issue is described in depth [here][desc]. C++14 no longer allows implicit conversion from iostream classes to void*. This patch comes directly from [PR spack#6][patch]. [desc]: http://stackoverflow.com/questions/38659115/make-fails-with-error-cannot-convert-stdistream-aka-stdbasic-istreamchar [patch]: agordon/libgtextutils#6 * mend
xavierandrade
pushed a commit
to xavierandrade/spack
that referenced
this pull request
Jun 16, 2017
* New gcc uses C++14 mode, this fixes implicit conversion The issue is described in depth [here][desc]. C++14 no longer allows implicit conversion from iostream classes to void*. This patch comes directly from [PR spack#6][patch]. [desc]: http://stackoverflow.com/questions/38659115/make-fails-with-error-cannot-convert-stdistream-aka-stdbasic-istreamchar [patch]: agordon/libgtextutils#6 * mend
EmreAtes
pushed a commit
to EmreAtes/spack
that referenced
this pull request
Jul 10, 2017
* New gcc uses C++14 mode, this fixes implicit conversion The issue is described in depth [here][desc]. C++14 no longer allows implicit conversion from iostream classes to void*. This patch comes directly from [PR spack#6][patch]. [desc]: http://stackoverflow.com/questions/38659115/make-fails-with-error-cannot-convert-stdistream-aka-stdbasic-istreamchar [patch]: agordon/libgtextutils#6 * mend
amklinv
pushed a commit
to spack/spack
that referenced
this pull request
Jul 17, 2017
* New gcc uses C++14 mode, this fixes implicit conversion The issue is described in depth [here][desc]. C++14 no longer allows implicit conversion from iostream classes to void*. This patch comes directly from [PR #6][patch]. [desc]: http://stackoverflow.com/questions/38659115/make-fails-with-error-cannot-convert-stdistream-aka-stdbasic-istreamchar [patch]: agordon/libgtextutils#6 * mend
healther
pushed a commit
to electronicvisions/spack
that referenced
this pull request
Jul 26, 2017
* New gcc uses C++14 mode, this fixes implicit conversion The issue is described in depth [here][desc]. C++14 no longer allows implicit conversion from iostream classes to void*. This patch comes directly from [PR #6][patch]. [desc]: http://stackoverflow.com/questions/38659115/make-fails-with-error-cannot-convert-stdistream-aka-stdbasic-istreamchar [patch]: agordon/libgtextutils#6 * mend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, libgtextutils fails to build with GCC6 [1]. See [2] for further details.
[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=811646
[2] https://gcc.gnu.org/gcc-6/porting_to.html