Skip to content

Commit

Permalink
New gcc uses C++14 mode, this fixes implicit conversion (spack#3392)
Browse files Browse the repository at this point in the history
* New gcc uses C++14 mode, this fixes implicit conversion

The issue is described in depth [here][desc].  C++14 no longer
allows implicit conversion from iostream classes to void*.

This patch comes directly from [PR spack#6][patch].

[desc]: http://stackoverflow.com/questions/38659115/make-fails-with-error-cannot-convert-stdistream-aka-stdbasic-istreamchar
[patch]: agordon/libgtextutils#6

* mend
  • Loading branch information
hartzell authored and diaena committed May 26, 2017
1 parent 8f34baa commit 7602070
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
1 change: 1 addition & 0 deletions var/spack/repos/builtin/packages/libgtextutils/package.py
Expand Up @@ -31,4 +31,5 @@ class Libgtextutils(AutotoolsPackage):
homepage = "https://github.com/agordon/libgtextutils"
url = "https://github.com/agordon/libgtextutils/releases/download/0.7/libgtextutils-0.7.tar.gz"

patch('text_line_reader.patch')
version('0.7', '593c7c62e3c76ec49f5736eed4f96806')
@@ -0,0 +1,10 @@
--- libgtextutils/src/gtextutils/text_line_reader.cpp.orig 2017-03-09 07:49:56.358283887 -0800
+++ libgtextutils/src/gtextutils/text_line_reader.cpp 2017-03-09 07:50:24.317503887 -0800
@@ -44,6 +44,6 @@
if (input_stream.eof())
return false;

- return input_stream ;
+ return static_cast<bool>(input_stream) ;
}

0 comments on commit 7602070

Please sign in to comment.