Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecation and shelving steps #122

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Update deprecation and shelving steps #122

merged 3 commits into from
Feb 25, 2021

Conversation

jacobdadams
Copy link
Member

Auditor currently updates any item listed in AGOLItems or AGOLItems_shelved based on the AGOL_ITEM_NAME, CATEGORY (AGOLItems_shelved ), and Authoritative (AGOLItems ) fields. Thus, Auditor will undo any changes made to the AGOL items directly if they're not also reflected in the tables.

The current instructions for noting a "deprecated" status don't mention modifying the tables, only the AGOL items themselves. I think a better way forward is to just make the appropriate changes in the tables and let Auditor modify the AGOL items as part of it's daily run.

Also added more info to the shelving process.

Copy link
Member

@steveoh steveoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for clarifying the auditor process

.github/ISSUE_TEMPLATE/2-deprecate-sgid-dataset.md Outdated Show resolved Hide resolved
- [ ] Unshare item from Open Data (name, completed: `2021/00/00`)
- currently achieved by either deleting the AGOL item, changing the `AGOL_ITEM_ID` field in `SGID.META.AGOLItems` to something other than an Item ID and manually removing the item from all SGID groups, or shelving the data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: will these instructions be simpler to follow as separate checkboxes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Open Data sharing is a little more nuanced/tightly coupled than I think we realized earlier. See agrc/auditor#52 for my thoughts on this. I felt it important to at least get something in here to note what was going on (my other thought was to delete this row completely because we don't have a manual way of unsharing it with Open Data without affecting other things)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the Authoritative field was set to d, could Auditor or some other process use that to update the AGOL_ITEM_ID to unshare it from Open Data?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could be a consideration for after we sort out the Open Data sharing tangle-up, yes.

@steveoh steveoh merged commit 8b3345a into main Feb 25, 2021
@steveoh steveoh deleted the deprecation-updates branch February 25, 2021 01:11
Copy link
Member

@ZachBeck ZachBeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants